Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that changing the Span async from OnStart is undefined behavior #2751

Closed
wants to merge 2 commits into from
Closed

Clarify that changing the Span async from OnStart is undefined behavior #2751

wants to merge 2 commits into from

Commits on Aug 25, 2022

  1. Clarify that changing the Span async from OnStart is undefined behavior 

    The reason to make this undefined behavior is because it is not guarantee that the span is still active after the call to OnStart finishes,
so instead of doing a very complicated synchronization logic which none of the SDK does, mark this as undefined behavior.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
    @bogdandrutu
    bogdandrutu committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    0f6d165 View commit details
    Browse the repository at this point in the history

  2. Update specification/trace/sdk.md 

    Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
    @yurishkuro
    Bogdan Drutu and yurishkuro committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    8c14e4f View commit details
    Browse the repository at this point in the history