Specify a low-memory temporality preference for the OTLP metrics exporter #2961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
reviewed
Nov 18, 2022
reyang
approved these changes
Nov 18, 2022
carlosalberto
approved these changes
Nov 18, 2022
jack-berg
reviewed
Nov 18, 2022
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
jack-berg
reviewed
Nov 28, 2022
jack-berg
approved these changes
Nov 28, 2022
Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2738
Changes
Adds a low-memory aggregation temporality preference configuration for the OTLP metrics exporter, "lowmemory" which configures the OTLP exporter to use delta temporality for synchronous Counter and Histogram instruments.
Related issue: #1891
Note that a parallel change #2960 specifies limits and states that SDKs SHOULD remove timeseries from memory when they are stale and Delta aggregation temporality is configured, which they will be able to do in conjunction with the "lowmemory" preference here.
Note that this could benefit users even when metrics data is collected by Prometheus servers. The OTel Collector's
prometheusexportersupports delta-to-cumulative translation, making it possible with a "lowmemory" OTLP exporter configuration to shift the memory requirement for cumulative timeseries calculation from the client to a collector.