Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eager exporting batch span processor #3024

Merged
merged 20 commits into from
Jan 13, 2023

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Dec 7, 2022

Fixes #849

Changes

Clarify that the BSP should export whenever the queue reaches the batch size or the scheduled delay timer completes, whichever is first.

@arminru arminru added area:sdk Related to the SDK spec:trace Related to the specification/trace directory labels Dec 13, 2022
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 30, 2022
@dyladan
Copy link
Member Author

dyladan commented Dec 30, 2022

I think this can be merged

specification/trace/sdk.md Outdated Show resolved Hide resolved
specification/trace/sdk.md Outdated Show resolved Hide resolved
specification/trace/sdk.md Outdated Show resolved Hide resolved
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs more clarification, please find my comments.

@dyladan
Copy link
Member Author

dyladan commented Jan 10, 2023

Dead link not mine

specification/trace/sdk.md Outdated Show resolved Hide resolved
specification/trace/sdk.md Outdated Show resolved Hide resolved
specification/trace/sdk.md Outdated Show resolved Hide resolved
specification/trace/sdk.md Outdated Show resolved Hide resolved
Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
specification/trace/sdk.md Outdated Show resolved Hide resolved
@dyladan
Copy link
Member Author

dyladan commented Jan 13, 2023

I think this can be merged

@reyang
Copy link
Member

reyang commented Jan 13, 2023

I'll merge it after the CI finished.

@reyang
Copy link
Member

reyang commented Jan 13, 2023

The markdown-link-check CI failed due to network latency fluctuation...

@reyang reyang closed this Jan 13, 2023
@reyang reyang reopened this Jan 13, 2023
@reyang reyang merged commit b45fa5e into open-telemetry:main Jan 13, 2023
@dyladan dyladan deleted the eager-bsp branch June 15, 2023 20:09
@dyladan dyladan restored the eager-bsp branch June 15, 2023 20:09
@dyladan dyladan deleted the eager-bsp branch June 15, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk Related to the SDK spec:trace Related to the specification/trace directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify whether BatchSpanProcessor scheduledDelayMillis is between batches or entire processing of queue