Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add table for OTLP/HTTP response code and client retry recommendation #3028

Merged
merged 9 commits into from
Dec 20, 2022
Merged

Add table for OTLP/HTTP response code and client retry recommendation #3028

merged 9 commits into from
Dec 20, 2022

Conversation

newly12
Copy link
Contributor

@newly12 newly12 commented Dec 12, 2022

Fixes #2915

Changes

Add table for OTLP/HTTP response code and client retry recommendation.

Related issues #2915

Related OTEP(s) #

@newly12 newly12 requested review from a team December 12, 2022 07:32
newly12 and others added 2 commits December 13, 2022 17:49
@newly12 @tigrannajaryan
Update specification/protocol/otlp.md
191f0bd 
Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
@newly12
Merge branch 'main' into http_status_code_table
beb250d
@jmacd
Copy link
Contributor

jmacd commented Dec 14, 2022

Please add a changelog entry and a spec-compiance-matrix entry. Thanks.

jack-berg
jack-berg approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry. Thanks!

@newly12
Copy link
Contributor Author

newly12 commented Dec 15, 2022

Not sure how spec-compiance-matrix should be updated, I suppose it's this row Honors retryable responses with backoff but I don't have much knowledge for all SDKs..

newly12 and others added 2 commits December 20, 2022 10:31
@newly12 @MrAlias
Update specification/protocol/otlp.md
9097776 
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@newly12
remove retryable column
5a920be
@carlosalberto carlosalberto merged commit ff19b9e into open-telemetry:main Dec 20, 2022
@jack-berg jack-berg mentioned this pull request Dec 20, 2022
Closed
@newly12 newly12 deleted the http_status_code_table branch December 21, 2022 01:50
@arminru arminru added the spec:protocol Related to the specification/protocol directory label Dec 21, 2022
carlosalberto pushed a commit that referenced this pull request Dec 21, 2022
@arminru
Fix changelog for #3028 (#3055)
25db497
@newly12 newly12 mentioned this pull request Dec 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosalberto carlosalberto carlosalberto approved these changes

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@MrAlias MrAlias MrAlias approved these changes

@jack-berg jack-berg jack-berg approved these changes

Assignees

@jmacd jmacd

Labels
spec:protocol Related to the specification/protocol directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OTLP/HTTP: Retry or no on status code 401, 403?
7 participants
@newly12 @jmacd @carlosalberto @tigrannajaryan @MrAlias @jack-berg @arminru