Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CHANGELOG.md #3053

Closed
wants to merge 2 commits into from
Closed

Update CHANGELOG.md #3053

wants to merge 2 commits into from

Conversation

haddasbronfman
Copy link
Member

according to #3050

@haddasbronfman
Update CHANGELOG.md
4489e54 
Change the declaration of 'pool.name' attribute.
@haddasbronfman haddasbronfman requested review from a team December 21, 2022 09:59
@haddasbronfman haddasbronfman mentioned this pull request Dec 21, 2022
Merged
@haddasbronfman
Update CHANGELOG.md
619eb6e 
remove empty line
arminru
arminru requested changes Dec 21, 2022
View reviewed changes
Copy link
Member

@arminru arminru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be added in #3050 directly so it's only merged atomically, otherwise the changelog might be inconsistent.

@haddasbronfman
Copy link
Member Author

This PR content is now part of this PR: #3050

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arminru arminru arminru requested changes

Assignees

@jmacd jmacd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haddasbronfman @arminru @jmacd