Change db.statement to only be collected if there is sanitization
#3127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rity vulnerabilities.
…metry-specification into sanitize_query_by_default
avzis
changed the title
joaopgrassi
reviewed
Jan 23, 2023
avzis
requested review from
arminru and
joaopgrassi
and removed request for
arminru and
joaopgrassi
# Conflicts: # CHANGELOG.md
joaopgrassi
approved these changes
Jan 27, 2023
|
@avzis I think this looks good.. I had my approve but then saw it's still in draft. Do you want to do more changes? |
carlosalberto
approved these changes
Jan 27, 2023
|
This PR can stop being a draft btw (unless you plan to add more content, as Joao mentioned). That way you should way more reviews ;) |
avzis
requested review from
trask,
yurishkuro,
pellared,
MrAlias,
blumamir,
arminru and
Oberon00
carlosalberto
approved these changes
Apr 4, 2023
trask
approved these changes
Apr 4, 2023
reyang
approved these changes
Apr 4, 2023
arminru
approved these changes
Apr 4, 2023
joaopgrassi
approved these changes
Apr 4, 2023
pellared
approved these changes
Apr 4, 2023
trask
changed the title
db.statement to only be collected if there is sanitization
|
@trask I will merge this and make it part of the April release, unless you think we should hold it for be May one. Let me know what you think. |
👍 |
jack-berg
pushed a commit
that referenced
this pull request
Apr 6, 2023
Relocate the changelog for #3127.
Closed
11 tasks
Merged
9 tasks
7 tasks
Merged
6 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a recommendation to disable DB_STATEMENT by default.
Fixes #3104
Changes
Currently DB_STATEMENT parameter is collecting the full query that is being made to a DB.
I suggest disabling this attribute by default, and giving users the option to opt-in into logging it.
It is also possible to give users a way to supply a sanitization function, in order to display only specific information.