Expand scope of faas.id to cloud.resource_id
#3188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbenson
force-pushed
the
tyler/faas
branch
from
46cc53f
to
a2aa3bb
Compare
tsloughter
approved these changes
Feb 8, 2023
jmacd
approved these changes
Feb 8, 2023
Oberon00
previously requested changes
Feb 9, 2023
arminru
added
area:semantic-conventions
lmolkova
approved these changes
Feb 13, 2023
|
FYI. I've pulled the first two commits out into a separate PR #3209. I'll try moving |
tylerbenson
added a commit
to tylerbenson/opentelemetry-specification
that referenced
this pull request
Feb 14, 2023
As per the discussion on open-telemetry#3188, we determined it is better to move rather than remove as this attribute is still important for some systems despite it containing duplicated information.
tylerbenson
force-pushed
the
tyler/faas
branch
from
fa58b5e
to
a2db39a
Compare
tylerbenson
changed the title
faas.id to cloud.resource_id
As per the discussion on open-telemetry#3188, we determined it is better to move rather than remove as this attribute is still important for some systems despite it containing duplicated information.
tylerbenson
force-pushed
the
tyler/faas
branch
from
a2db39a
to
71d6dac
Compare
tylerbenson
requested review from
Oberon00,
lmolkova and
jmacd
and removed request for
Oberon00,
lmolkova and
jmacd
|
Hey @Oberon00
You mean adding a reference/link from the FaaS semconv table to this section? |
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
|
Btw @Oberon00 Following on this: once we decide how to proceed with open-telemetry/oteps#222 we should also double check expectations here regarding ECS. FWIW I think ECS is a better, clearer, cleaner semconv reference, with |
Exactly (using the |
I think you should decide on this rather sooner than later otherwise lots of work on the semantic conventions (such as this PR) and also potentially the tooling may go to waste. |
# Conflicts: # schemas/1.19.0 # specification/resource/semantic_conventions/faas.md # specification/trace/semantic_conventions/faas.md # specification/trace/semantic_conventions/instrumentation/aws-lambda.md
Oberon00
reviewed
Feb 22, 2023
jsuereth
pushed a commit
to jsuereth/opentelemetry-specification
that referenced
this pull request
Feb 28, 2023
## Changes As per the discussion on open-telemetry#3188, we determined it is better to move rather than remove as this attribute is still important for some systems despite it containing duplicated information.
Oberon00
added a commit
to dynatrace-oss-contrib/opentelemetry-specification
that referenced
this pull request
Mar 21, 2023
These places were removed when open-telemetry#3188 in its original form removed faas.id without replacement and weren't added back after changing it to introduce cloud.resource_id instead.
Oberon00
added a commit
to dynatrace-oss-contrib/opentelemetry-specification
that referenced
this pull request
Mar 21, 2023
These places were removed when open-telemetry#3188 in its original form removed faas.id without replacement and weren't added back after changing it to introduce cloud.resource_id instead.
carlosalberto
pushed a commit
that referenced
this pull request
Apr 11, 2023
These places were removed when #3188 in its original form removed faas.id without replacement and weren't added back after changing it to introduce cloud.resource_id instead. Editorial change, no CHANGELOG or issue.
5 tasks
codeboten
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Oct 6, 2023
…26486) Context: GoogleCloudPlatform/opentelemetry-operations-go#679 faas.id was removed from the semantic conventions: open-telemetry/opentelemetry-specification#3188 We were previously using it improperly to store the instance id of the faas, which should be mapped to faas.instance instead. --------- Co-authored-by: Alex Boten <aboten@lightstep.com>
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…pen-telemetry#26486) Context: GoogleCloudPlatform/opentelemetry-operations-go#679 faas.id was removed from the semantic conventions: open-telemetry/opentelemetry-specification#3188 We were previously using it improperly to store the instance id of the faas, which should be mapped to faas.instance instead. --------- Co-authored-by: Alex Boten <aboten@lightstep.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
As per the discussion on #3188, we determined it is better to move rather than remove as this attribute is still important for some systems despite it containing duplicated information.