Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename http.user_agent to user_agent.original #3190

Merged
merged 15 commits into from
Mar 2, 2023
Merged

Rename http.user_agent to user_agent.original #3190

merged 15 commits into from
Mar 2, 2023

Conversation

trask
Copy link
Member

@trask trask commented Feb 9, 2023 •
edited
Loading

Fixes #3180

Changes

Renames http.user_agent to user_agent.original.

@trask trask force-pushed the user-agent branch 2 times, most recently from 87e986c to 00cbb2f Compare February 9, 2023 00:38
@trask trask changed the title Rename http.user_agent to user_agent.full Rename http.user_agent to user_agent.original Feb 9, 2023
@trask trask added area:semantic-conventions Related to semantic conventions semconv:HTTP spec:trace Related to the specification/trace directory labels Feb 9, 2023
@trask trask marked this pull request as ready for review February 13, 2023 23:14
@trask trask requested review from a team February 13, 2023 23:14
@arminru arminru added the area:client RUM and other client instrumentation issues label Feb 14, 2023
arminru
arminru reviewed Feb 14, 2023
View reviewed changes
schemas/1.18.0 Outdated Show resolved Hide resolved
@MSNev
Copy link

MSNev commented Feb 14, 2023

Do we want to include removal / renaming of browser.user_agent as part of this or as a separate PR?

@trask
Copy link
Member Author

trask commented Feb 14, 2023

Do we want to include removal / renaming of browser.user_agent as part of this or as a separate PR?

@MSNev I added to this PR, ptal 👍

@carlosalberto
Copy link
Contributor

@open-telemetry/specs-approvers Please review. Hopefully this doesn't take anybody by surprise, etc.

tigrannajaryan
tigrannajaryan previously requested changes Feb 22, 2023
View reviewed changes
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking briefly to decide what to do with #3245 before merging this PR.

@tigrannajaryan
Copy link
Member

FYI, the schema checker tool is incorrect. I am fixing it now. Don't merge this.

tigrannajaryan
tigrannajaryan reviewed Feb 24, 2023
View reviewed changes
schemas/1.19.0 Outdated Show resolved Hide resolved
@tigrannajaryan
Copy link
Member

Fix submitted to build tools: open-telemetry/build-tools#138

@tigrannajaryan tigrannajaryan mentioned this pull request Feb 27, 2023
Merged
tigrannajaryan added a commit to tigrannajaryan/opentelemetry-specification that referenced this pull request Feb 27, 2023
@tigrannajaryan
Update build-tools to 1.16.0
5564fcf 
build-tools 1.16.0 was just released and is necessary to unblock
open-telemetry#3190
@tigrannajaryan tigrannajaryan mentioned this pull request Feb 27, 2023
Merged
@tigrannajaryan
Copy link
Member

Here is the PR to update to latest build-tools which includes the fix to schema check tool: #3259

Once that is merged this PR needs to be rebased.

tigrannajaryan added a commit that referenced this pull request Feb 27, 2023
@tigrannajaryan
Update build-tools to 1.16.0 (#3259)
203a8b4 
build-tools 1.16.0 was just released and is necessary to unblock
#3190
@tigrannajaryan
Copy link
Member

This can be rebased now and the schema check should pass.

@trask
Copy link
Member Author

trask commented Feb 27, 2023

@tigrannajaryan thx for fixing this, schema check is passing now. can you remove your "request changes"? thx!

@tigrannajaryan tigrannajaryan dismissed their stale review February 27, 2023 23:54

schema check fixed

jsuereth pushed a commit to jsuereth/opentelemetry-specification that referenced this pull request Feb 28, 2023
@tigrannajaryan @jsuereth
Update build-tools to 1.16.0 (open-telemetry#3259)
a32984f 
build-tools 1.16.0 was just released and is necessary to unblock
open-telemetry#3190
@carlosalberto
Copy link
Contributor

@trask Conflicts need to be solved but otherwise (it sounds like) we are ready to merge this.

@carlosalberto
Copy link
Contributor

Merging after letting this PR settle and get some more attention.

@carlosalberto carlosalberto merged commit 0e19398 into open-telemetry:main Mar 2, 2023
@MrAlias MrAlias mentioned this pull request Mar 6, 2023
Closed
@lmolkova lmolkova mentioned this pull request Mar 7, 2023
Closed
jsuereth pushed a commit to jsuereth/otel-semconv-test that referenced this pull request Apr 19, 2023
@tigrannajaryan
Update build-tools to 1.16.0 (#3259)
cc67748 
build-tools 1.16.0 was just released and is necessary to unblock
open-telemetry/opentelemetry-specification#3190
@trask trask mentioned this pull request Apr 20, 2023
Merged
This was referenced Apr 25, 2023
Closed
Merged
@trask trask deleted the user-agent branch April 26, 2023 23:06
jsuereth pushed a commit to open-telemetry/semantic-conventions that referenced this pull request May 11, 2023
@tigrannajaryan
Update build-tools to 1.16.0 (#3259)
e9d9309 
build-tools 1.16.0 was just released and is necessary to unblock
open-telemetry/opentelemetry-specification#3190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosalberto carlosalberto carlosalberto approved these changes

@tigrannajaryan tigrannajaryan tigrannajaryan left review comments

@MrAlias MrAlias MrAlias left review comments

@arminru arminru arminru left review comments

@lmolkova lmolkova lmolkova approved these changes

@pyohannes pyohannes pyohannes approved these changes

@reyang reyang reyang approved these changes

@MSNev MSNev MSNev approved these changes

Assignees

@bogdandrutu bogdandrutu

Labels
area:client RUM and other client instrumentation issues area:semantic-conventions Related to semantic conventions semconv:HTTP spec:trace Related to the specification/trace directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generalize the http.user_agent attribute to user_agent.*
10 participants
@trask @MSNev @carlosalberto @tigrannajaryan @lmolkova @MrAlias @arminru @pyohannes @reyang @bogdandrutu