Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make net.sock.host.port conditionally required #3246

Merged
merged 6 commits into from
Mar 2, 2023
Merged

Make net.sock.host.port conditionally required #3246

merged 6 commits into from
Mar 2, 2023

Conversation

trask
Copy link
Member

@trask trask commented Feb 22, 2023

Based on discussion at #3228 (comment)

Changes

Mark net.sock.host.port as conditionally required.

As @Oberon00 says in #3228 (comment):

Under [the current] condition, it is required to set the net.sock.host.port, because otherwise one would assume that it is equal to net.host.port and it would be wrong.

@trask trask requested review from a team February 22, 2023 16:10
@arminru arminru added semconv:HTTP area:semantic-conventions Related to semantic conventions spec:trace Related to the specification/trace directory labels Feb 28, 2023
@trask @Oberon00
Update semantic_conventions/trace/general.yaml
8d2dc68 
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
@reyang reyang merged commit 7ad3ac3 into open-telemetry:main Mar 2, 2023
@trask trask deleted the net-sock-host-port branch March 2, 2023 22:23
@MrAlias MrAlias mentioned this pull request Mar 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@Oberon00 Oberon00 Oberon00 approved these changes

@lmolkova lmolkova lmolkova approved these changes

@arminru arminru arminru approved these changes

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

Assignees

@arminru arminru

Labels
area:semantic-conventions Related to semantic conventions semconv:HTTP spec:trace Related to the specification/trace directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@trask @Oberon00 @lmolkova @arminru @reyang @mateuszrzeszutek