Rename nonheap to non_heap #3250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
added
area:semantic-conventions
jack-berg
approved these changes
Feb 22, 2023
mateuszrzeszutek
approved these changes
Feb 23, 2023
arminru
approved these changes
Feb 23, 2023
reyang
approved these changes
Feb 23, 2023
carlosalberto
approved these changes
Feb 23, 2023
jsuereth
pushed a commit
to jsuereth/opentelemetry-specification
that referenced
this pull request
Feb 28, 2023
Fixes open-telemetry/opentelemetry-java-instrumentation#7876 (the implementation used `non_heap`, which seems better) ## Changes Renames JVM metric attribute value from `nonheap` to `non_heap`. --------- Co-authored-by: Carlos Alberto Cortez <calberto.cortez@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes open-telemetry/opentelemetry-java-instrumentation#7876 (the implementation used
non_heap, which seems better)Changes
Renames JVM metric attribute value from
nonheaptonon_heap.