Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING rename net.app.protocol.(name|version) to net.protocol.(name|version) and replace http.flavor with net.protocol.(name|version) #3272

Merged
merged 15 commits into from
Mar 10, 2023

Conversation

trask
Copy link
Member

@trask trask commented Mar 2, 2023

Fixes #3215 -- renaming net.app.protocol.(name|version) to net.protocol.(name|version)
Fixes #2626 -- replacing http.flavor with net.protocol.(name|version)

Changes

Renames net.app.protocol.(name|version) to net.protocol.(name|version) and replaces http.flavor with net.protocol.(name|version).

Note: there's no schema transformation available today for splitting http.flavor into net.protocol.(name|version) (#3162)

@trask trask changed the title BREAKING Renames net.app.transport.(name|version) to net.transport.(name|version) and replaces http.flavor with net.transport.(name|version) BREAKING rename net.app.transport.(name|version) to net.transport.(name|version) and replace http.flavor with net.transport.(name|version) Mar 2, 2023
@trask trask force-pushed the rename-net-app-transport-attrs branch from 78d9bcb to bbd13ac Compare March 2, 2023 03:44
CHANGELOG.md Outdated Show resolved Hide resolved
semantic_conventions/http-common.yaml Outdated Show resolved Hide resolved
trask and others added 2 commits March 1, 2023 21:43
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
CHANGELOG.md Outdated Show resolved Hide resolved
@trask trask changed the title BREAKING rename net.app.transport.(name|version) to net.transport.(name|version) and replace http.flavor with net.transport.(name|version) BREAKING rename net.app.protocol.(name|version) to net.protocol.(name|version) and replace http.flavor with net.protocol.(name|version) Mar 2, 2023
@trask trask marked this pull request as ready for review March 2, 2023 05:52
@trask trask requested review from a team March 2, 2023 05:52
Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - as I think it's ok to default protocol to the application-layer and then provide other protocol attributes for non-standard layer protocols, but was curious if the intent here is just to use protocol.name as the "outermost"/"highest" protocol used in the trace?

semantic_conventions/trace/general.yaml Show resolved Hide resolved
mateuszrzeszutek pushed a commit to open-telemetry/opentelemetry-java-instrumentation that referenced this pull request Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants