Remove underspecified and unused Span decorator from Trace SDK. #3363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsloughter
force-pushed
the
rm-decorators
branch
from
cdcb205
to
a14c04b
Compare
tsloughter
force-pushed
the
rm-decorators
branch
from
a14c04b
to
6ba4a82
Compare
arminru
added
area:sdk
arminru
reviewed
Apr 4, 2023
There was a problem hiding this comment.
@tsloughter I remember this was discussed already but I can't find the related issue. Can you please link it to your PR?
|
I don't think there is an issue (and didn't find one after a quick search). It was discussed in a Spec SIG meeting. |
bogdandrutu
approved these changes
Apr 4, 2023
MrAlias
approved these changes
Apr 4, 2023
Aneurysm9
reviewed
Apr 4, 2023
specification/trace/semantic_conventions/instrumentation/aws-lambda.md
Outdated
Show resolved
Hide resolved
tsloughter
force-pushed
the
rm-decorators
branch
from
a081f97
to
77c8edd
Compare
arminru
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
LGTM provided @Aneurysm9 comment is addressed. This also looks like a stray change to me.
Aneurysm9
approved these changes
Apr 4, 2023
reyang
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This removes the "decorate" language from span processors. Technically a breaking change but since consensus seemed to be that something new needed to be designed I figured it best to get it out of the spec first.
Open question if the "for advanced scenarios such as tagging or filtering" part should be left in. I'd say it doesn't apply to custom processors but you technically could use them to do that in OnStart.