add name suggestion to prometheus exporter option #3837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
force-pushed
the
codeboten/add-with_resource_as_constant_labels
branch
from
d76d8ae
to
258ae89
Compare
jack-berg
reviewed
Jan 19, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
jack-berg
approved these changes
Feb 15, 2024
arminru
approved these changes
Feb 15, 2024
MrAlias
reviewed
Feb 15, 2024
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
@codeboten Should we re-open this? |
|
@carlosalberto yes please |
|
@jack-berg can you re-open this issue please |
codeboten
force-pushed
the
codeboten/add-with_resource_as_constant_labels
branch
from
fa83641
to
0835e3c
Compare
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten
force-pushed
the
codeboten/add-with_resource_as_constant_labels
branch
from
0835e3c
to
da07322
Compare
carlosalberto
approved these changes
Apr 17, 2024
|
cc @dashpole |
dashpole
approved these changes
Apr 17, 2024
MrAlias
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Similarly to the other options listed in the Prometheus exporter specification, adding a suggested name for the option to apply resource attributes as metric attributes.
For non-trivial changes, follow the change proposal process.
CHANGELOG.mdfile updated for non-trivial changesspec-compliance-matrix.mdupdated if necessary