Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.31.0 #3921

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Conversation

carlosalberto
Copy link
Contributor

@carlosalberto carlosalberto commented Mar 5, 2024

@carlosalberto carlosalberto requested review from a team March 5, 2024 18:00
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@carlosalberto
Copy link
Contributor Author

So in general we don't add editorial fixes to the CHANGELOG but the two mentioned ones are not one or two-liners, but actual clarifications, so I have mixed feelings about them being included or not.

@MrAlias
Copy link
Contributor

MrAlias commented Mar 6, 2024

Can we include the following PRs in the release?

They both look ready to merge.

CHANGELOG.md Outdated Show resolved Hide resolved
@carlosalberto
Copy link
Contributor Author

Following up on the (small) issue regarding editorial changes, what about:

  1. Do not include one-two liner changes in the CHANGELOG
  2. Editorial changes that are rather long or are actual clarifications could go into a separate "Editorial" section?

Alternatively, we could decide what PRs go or not into CHANGELOG. I'm fine either way!

cc @reyang

Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
@carlosalberto
Copy link
Contributor Author

FYI @MrAlias #3889 was changed to draft as it needs more discussion, but #3853 was merged.

@MrAlias
Copy link
Contributor

MrAlias commented Mar 13, 2024

FYI @MrAlias #3889 was changed to draft as it needs more discussion, but #3853 was merged.

Right, sorry I should have said I understood that explicitly when I approved. Not blocking on getting that PR merged, all good 👍

@carlosalberto carlosalberto merged commit 3985e21 into open-telemetry:main Mar 13, 2024
7 checks passed
@carlosalberto carlosalberto deleted the release-1-31-0 branch March 13, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants