Resolves Open Feedback re: Prohibiting Complex Types #3926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmccleary
changed the title
jack-berg
reviewed
Mar 6, 2024
jack-berg
reviewed
Mar 6, 2024
pellared
approved these changes
Mar 7, 2024
carlosalberto
approved these changes
Mar 7, 2024
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Rewrite bullets, to clarify reasoning.
pyohannes
approved these changes
Mar 11, 2024
Co-authored-by: Johannes Tax <johannes@johannes.tax>
jmacd
approved these changes
Mar 11, 2024
|
Sounds we are good to go. cc @jack-berg |
jack-berg
approved these changes
Mar 11, 2024
arminru
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Resolves open comments from PR (#3858)
Clarify the "why" w/o redefining metadata (See comment)
Keep all the new standard attribute content together in one place
This addresses issue (#3925).