Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tracer#Enabled, Instrument#Enabled and corresponding SDK behavior #4063

Merged
merged 9 commits into from
Jun 3, 2024
Merged

Add Tracer#Enabled, Instrument#Enabled and corresponding SDK behavior #4063

merged 9 commits into from
Jun 3, 2024

Conversation

jack-berg
Copy link
Member

@jack-berg jack-berg commented May 28, 2024 •
edited by reyang
Loading

Builds off #4020 to extend the Enabled API to Tracer and metrics Instrument.

Adds language to Log SDK, Metrics SDK, and Trace SDK for how scope config is used to resolve the Enabled operation.

This was discussed in #3867 but punted on in #3877 as discussed here.

@jack-berg jack-berg requested review from a team May 28, 2024 20:48
trask
trask approved these changes May 28, 2024
View reviewed changes
specification/trace/api.md Outdated Show resolved Hide resolved
trask
trask reviewed May 28, 2024
View reviewed changes
specification/trace/api.md Outdated Show resolved Hide resolved
@pellared @trask
Update specification/trace/api.md
c9e0e84 
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@marcalff marcalff mentioned this pull request May 30, 2024
Open
reyang
reyang approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from feature parity perspective.

@reyang reyang changed the title Add Tracer#Enabled, Meter#Enabled and corresponding SDK behavior Add Tracer#Enabled, Instrument#Enabled and corresponding SDK behavior May 31, 2024
@jack-berg jack-berg merged commit d0bfe08 into open-telemetry:main Jun 3, 2024
6 checks passed
jack-berg added a commit to jack-berg/opentelemetry-specification that referenced this pull request Jun 4, 2024
@jack-berg
Add missing changelog entry for open-telemetry#4063
201d5dc
jack-berg added a commit to jack-berg/opentelemetry-specification that referenced this pull request Jun 4, 2024
@jack-berg
Add missing changelog entry for open-telemetry#4063
487c798
@jack-berg jack-berg mentioned this pull request Jun 4, 2024
Merged
reyang pushed a commit that referenced this pull request Jun 6, 2024
@jack-berg
Add missing changelog entry for #4063 (#4068)
c99b5f8
This was referenced Jun 12, 2024
Closed
Closed
@lmolkova lmolkova mentioned this pull request Jul 23, 2024
Closed
This was referenced Sep 3, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask