Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data point flags to the metric data model #4135

Merged
merged 13 commits into from
Aug 8, 2024
Merged

Add data point flags to the metric data model #4135

merged 13 commits into from
Aug 8, 2024

Conversation

pyohannes
Copy link
Contributor

Fixes #4053

Changes

This PR extends the metric data model with data point flags, which were added to the protocol in open-telemetry/opentelemetry-proto#316.

@reyang reyang added the spec:metrics Related to the specification/metrics directory label Jul 9, 2024
@pyohannes pyohannes marked this pull request as ready for review July 16, 2024 13:17
@pyohannes pyohannes requested review from a team July 16, 2024 13:17
@pyohannes pyohannes mentioned this pull request Jul 18, 2024
Closed
mx-psi
mx-psi approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

arminru
arminru reviewed Jul 19, 2024
View reviewed changes
specification/metrics/data-model.md Outdated Show resolved Hide resolved
specification/metrics/data-model.md Outdated Show resolved Hide resolved
@carlosalberto
Copy link
Contributor

Overall LGTM but why (still) experimental?

@mariomac mariomac mentioned this pull request Jul 22, 2024
Closed
@marctc marctc mentioned this pull request Jul 25, 2024
Merged
4 tasks
carlosalberto and others added 4 commits August 6, 2024 15:18
@carlosalberto
Update specification/metrics/data-model.md
9b6b926
@carlosalberto @arminru
Update specification/metrics/data-model.md
16a2b2a 
Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
@carlosalberto @arminru
Update specification/metrics/data-model.md
d6f4c96 
Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
@carlosalberto
Merge branch 'main' into metric-data-point-flags
2803963
@carlosalberto
Copy link
Contributor

Merging this as stable, after we discussed this last week at the Spec call. We will include this in our August release, given it has enough answers and the proto model is released already, etc.

@carlosalberto carlosalberto merged commit f426c11 into open-telemetry:main Aug 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsuereth jsuereth jsuereth approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

@dashpole dashpole dashpole approved these changes

@arminru arminru arminru left review comments

@zeitlinger zeitlinger zeitlinger approved these changes

@jmacd jmacd jmacd approved these changes

@mx-psi mx-psi mx-psi approved these changes

@MrAlias MrAlias MrAlias approved these changes

@reyang reyang reyang approved these changes

Assignees

@arminru arminru

Labels
spec:metrics Related to the specification/metrics directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DataPoint Flags are not mentioned in the Metrics Data Model
10 participants
@pyohannes @carlosalberto @jsuereth @zeitlinger @dashpole @jmacd @mx-psi @MrAlias @arminru @reyang