Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagators API: Update HTTP header RFC reference to 9110 #4153

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Propagators API: Update HTTP header RFC reference to 9110 #4153

merged 2 commits into from
Aug 1, 2024

Conversation

hiroyaonoe
Copy link
Contributor

Fixes #3444

Changes

Please provide a brief description of the changes here.

I updated the Propagators API documentation to reference RFC9110 Section 5, which specifies the latest HTTP Header Fields specification.

For non-trivial changes, follow the change proposal process.

@hiroyaonoe hiroyaonoe requested review from a team July 17, 2024 05:35
@MrAlias
Copy link
Contributor

MrAlias commented Jul 17, 2024 •
edited
Loading

Are there changes between the two RFCs that implementations need to be aware of?

@github-actions GitHub Actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 25, 2024
@pellared
Copy link
Member

pellared commented Jul 25, 2024 •
edited
Loading

Are there changes between the two RFCs that implementations need to be aware of?

https://datatracker.ietf.org/doc/html/rfc9110/#name-changes-from-rfc-7230

I found nothing breaking in the context of the line where we update the hyperlink. I also double-checked the actual content and the field name has the same syntax.

@pellared pellared added editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. and removed Stale labels Jul 25, 2024
@hiroyaonoe
Copy link
Contributor Author

Sorry for the late response.
There is no difference between the two RFCs.

@carlosalberto carlosalberto merged commit e723fb2 into open-telemetry:main Aug 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosalberto carlosalberto carlosalberto approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@lmolkova lmolkova lmolkova approved these changes

@pellared pellared pellared approved these changes

Assignees

@yurishkuro yurishkuro

Labels
editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Propagators API: RFC7230 has been obsoleted by RFC9110 and RFC9112
7 participants
@hiroyaonoe @MrAlias @pellared @carlosalberto @bogdandrutu @lmolkova @yurishkuro