Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor description of span kind #4178

Merged
merged 10 commits into from
Sep 3, 2024

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Aug 6, 2024

Fixes #3172

(Built on top of #4088)

Changes

  • Explains kinds without assuming presence of parent/children
  • Adds links as another correlation mechanism
  • Normalizes nested client spans even further - database, messaging, RPC, and LLM semantic conventions require CLIENT kind for logical client operation.
  • Does not touch INTERNAL kind yet - What's INTERNAL span kind and when it should be used #4179

specification/trace/api.md Outdated Show resolved Hide resolved
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 15, 2024
@lmolkova lmolkova force-pushed the refactor-span-kind-another-try branch from f81dfad to 152e677 Compare August 18, 2024 17:09
@lmolkova lmolkova marked this pull request as ready for review August 18, 2024 17:09
@lmolkova lmolkova requested review from a team August 18, 2024 17:09
specification/trace/api.md Outdated Show resolved Hide resolved
specification/trace/api.md Outdated Show resolved Hide resolved
specification/trace/api.md Outdated Show resolved Hide resolved
specification/trace/api.md Outdated Show resolved Hide resolved
lmolkova and others added 4 commits August 23, 2024 14:50
Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
specification/trace/api.md Outdated Show resolved Hide resolved
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Copy link

github-actions bot commented Sep 3, 2024

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Sep 3, 2024
@lmolkova lmolkova reopened this Sep 3, 2024
@lmolkova lmolkova merged commit e9a2b00 into open-telemetry:main Sep 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify semantic of SpanKind regarding parent/child relationships
9 participants