Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code example in data-model.md #4192

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Fix code example in data-model.md #4192

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f0a874
Fix code example in data-model.md
carsonip Aug 22, 2024
42e3728
Update data-model.md
carsonip Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions specification/metrics/data-model.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -874,9 +874,9 @@ The reverse mapping function for positive scales is:

```golang
// LowerBoundary computes the bucket boundary for positive scales.
func LowerBoundary(index int) float64 {
func LowerBoundary(index, scale int) float64 {
inverseFactor := math.Ldexp(math.Ln2, -scale)
return math.Exp(index * inverseFactor), nil
return math.Exp(index * inverseFactor)
}
```

Expand All @@ -890,11 +890,11 @@ reference implementation, for example, the above formula computes
to subtract `1<<scale` from the index and multiply the result by `2`.

```golang
func LowerBoundary(index int) float64 {
func LowerBoundary(index, scale int) float64 {
// Use this form in case the equation above computes +Inf
// as the lower boundary of a valid bucket.
inverseFactor := math.Ldexp(math.Ln2, -scale)
return 2.0 * math.Exp((index - (1 << scale)) * inverseFactor), nil
return 2.0 * math.Exp((index - (1 << scale)) * inverseFactor)
}
```

Expand Down
Loading