Probability sampler composition rules #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unknown in the span data
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
|
@open-telemetry/specs-trace-approvers These are minor modifications to the text of OTEP 168 and 170, they do not substantially change the content they just spell it out more clearly and change a few terms. The reason you should review this PR is that it includes a substantial tract of text to be inserted into the specification after it merges, related to the span data model discussed in open-telemetry/opentelemetry-specification#1929. |
oertl
reviewed
Sep 30, 2021
oertl
reviewed
Sep 30, 2021
|
@open-telemetry/specs-trace-approvers please approve minor edits to the already-merged sampling OTEPs 168 and 170. |
yurishkuro
reviewed
Oct 4, 2021
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
yurishkuro
approved these changes
Oct 4, 2021
oertl
approved these changes
Oct 4, 2021
|
@open-telemetry/specs-trace-approvers I would like this to merge, has several approvals already. |
yurishkuro
approved these changes
Oct 10, 2021
carlosalberto
approved these changes
Oct 11, 2021
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
…acd/170composition
jsuereth
approved these changes
Oct 12, 2021
arminru
approved these changes
Oct 14, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OTEP #168 spawned a very long comment thread here:
#168 (comment)
This PR is an update to the text of OTEP 170 with more detail on composing probability and non-probability samplers.
This changes the name used in OTEP 170 for "head trace sampling" to "parent trace sampling" to better fit the model where spans can make independent decisions.
This uses "head trace sampling" only to describe sampling decisions being made at the root of the trace.
This changes the field returned by the Sampler to be named
log_adjusted_countsince it applies to both the new span and the new child context, not the "head".cc: @oertl