Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase markdown-link-check timeout #393

Merged

Conversation

joaopgrassi
Copy link
Member

Currently the markdown link check if failing on all PRs because of https://web.archive.org/web/20180321091318/http://www.onlamp.com/pub/a/linux/2000/11/16/LinuxAdmin.html.

The link is not dead but it's really unreliable and takes long to load most of the times. As a first quick fix, we can try increasing the tool timeout. Went with 30s which may be quite long, but I assume the rest of pages load fast, meaning I think it won't affect the total task duration.

@joaopgrassi joaopgrassi requested review from a team October 12, 2023 11:05
@arminru
Copy link
Member

arminru commented Oct 12, 2023

Temporarily bypassing branch protection requirements so we can get our main branch and open PR builds green again
cc @open-telemetry/specs-semconv-maintainers

@arminru arminru merged commit f07ad81 into open-telemetry:main Oct 12, 2023
10 checks passed
@arminru arminru deleted the increase-link-check-timeout branch October 12, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants