Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align system.cpu.state's definition with this of process.cpu.state #765

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Feb 23, 2024

Fixes #563

Changes

This PR aligns the definition of the system.cpu.state's with this of process.cpu.state. Specifically it adds the same constraint of process.cpu.states as mentioned at #563 (comment).

Merge requirement checklist

@ChrsMark ChrsMark self-assigned this Feb 23, 2024
@ChrsMark ChrsMark requested review from a team February 23, 2024 13:06
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
model/metrics/system-metrics.yaml Show resolved Hide resolved
@joaopgrassi
Copy link
Member

Shouldn't we instead move the attribute to the registry, and simply re-use it in process/system metrics? There's also this which is related #681

@ChrsMark
Copy link
Member Author

ChrsMark commented Mar 4, 2024

Thank's @joaopgrassi for pointing to this. Check #765 (comment).

@arminru arminru merged commit 3edef61 into open-telemetry:main Mar 11, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Is possible to align process.cpu.time,utilization metrics defintion to system.cpu.time,utilization
6 participants