Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move HTTP client metrics out of .NET conventions #801

Conversation

joaopgrassi
Copy link
Member

Fixes #800

Changes

This PR moves HTTP client metrics (and one attribute) from the .NET metrics model to the general HTTP one.

It removes MD generation from .NET metric definition as it's frozen in time and should not get any updates or changes on the common metric.

It helps to untie .NET semconv stability from the unstable OTel parts it depends upon and helps with #781

Related to #785

Merge requirement checklist

@joaopgrassi joaopgrassi requested review from a team March 7, 2024 10:44
model/metrics/http.yaml Outdated Show resolved Hide resolved
model/metrics/http.yaml Outdated Show resolved Hide resolved
model/metrics/http.yaml Outdated Show resolved Hide resolved
model/metrics/http.yaml Outdated Show resolved Hide resolved
model/metrics/http.yaml Outdated Show resolved Hide resolved
model/metrics/http.yaml Outdated Show resolved Hide resolved
model/metrics/http.yaml Outdated Show resolved Hide resolved
model/metrics/http.yaml Outdated Show resolved Hide resolved
model/metrics/http.yaml Outdated Show resolved Hide resolved
model/metrics/http.yaml Outdated Show resolved Hide resolved
@lmolkova
Copy link
Contributor

@antonfirsov could you please take another look?

@lmolkova
Copy link
Contributor

lmolkova commented Mar 12, 2024

also //cc @open-telemetry/dotnet-approvers @open-telemetry/semconv-dotnet-approver

docs/http/http-metrics.md Outdated Show resolved Hide resolved
@lmolkova lmolkova merged commit cfff890 into open-telemetry:main Mar 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Move common HTTP client metrics out from .NET metrics definitions yaml
7 participants