compat-suse: fix infiniband type detection from ifname

[cfconrad]

• Restrict Infiniband configuration detection by ifcfg filename to /^ib[0-9]+(\.[a-fA-F0-9]+)?$/
• Decouple the ifcfg name from the Infiniband parent interface name and allow to set parent device via IPOIB_DEVICE and the pkey via IPOIB_PKEY separately. These variables take precedence over the pkey and device in the ifcfg filename.

[mtomaschewski]

I'm not sure if the code makes the variable vs. from ifname parsing the right way,
when IPOIB variables are set or not... e.g. for foo.bar with IPOIB=yes only...

As we're cleaning up here, I'd also cover the pkey range (excl. vs incl.) in validate.

[mtomaschewski]

I'd change the "foo or bar, I don't know" + checking pkey & device twice and use instead (pasted diff):

-	if ((pkey == NULL) != (device == NULL)) {

-		ni_error("ifcfg-%s: Missing one of IPOIB_DEVICE or IPOIB_PKEY variable",

-				dev->name);

-		ni_string_free(&device);

-		return -1;

-	}

-

-	if (pkey) {

+	if (pkey || device) {

 		unsigned long tmp = ~0UL;

 

 		if (ni_parse_ulong(pkey, &tmp, 16) < 0 || tmp > 0xffff) {

-			ni_error("ifcfg-%s: Cannot parse infiniband child key number",

-				dev->name);

+			ni_error("ifcfg-%s: %s %s partition key (IPOIB_PKEY)", dev->name,

+					pkey ? "Cannot parse" : "Missing",

+					ni_linktype_type_to_name(NI_IFTYPE_INFINIBAND_CHILD));

 			ni_string_free(&device);

 			return -1;

 		}

 

 		if (!ni_netdev_name_is_valid(device)) {

-			ni_error("ifcfg-%s: %s parent device name is not valid",

-					dev->name, ni_linktype_type_to_name(NI_IFTYPE_INFINIBAND_CHILD));

+			ni_error("ifcfg-%s: %s %s parent device name (IPOIB_DEVICE)", dev->name,

+					device ? "Invalid" : "Missing",

+					ni_linktype_type_to_name(NI_IFTYPE_INFINIBAND_CHILD));

 			ni_string_free(&device);

 			return -1;

 		}

[mtomaschewski]

LGTM, thanks!