Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat-suse: fix dummy type detection from ifname #1016

Merged
merged 2 commits into from
May 24, 2024

Conversation

cfconrad
Copy link
Collaborator

  • If the new DUMMY=yes/no or deprecated INTERFACETYPE=dummy variable aren't set, consider only /^dummy[0-9]+$/ interface names as dummy and do not cause conflicts with e.g. correct vlan config on dummy0.42 interfaces.
  • Create ifcfg-dummy.5.in from markdown file.

mtomaschewski
mtomaschewski previously approved these changes May 22, 2024
Copy link
Member

@mtomaschewski mtomaschewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

When the (new) DUMMY=yes/no or (deprecated) INTERFACETYPE=dummy variable
aren't set, consider only dummy[0-9]+ interface names as dummy and do not
cause conflicts with e.g. correct vlan config on dummy0.42 interfaces.
Add ifcfg-dummy.5.md source improved to be more precise and
add DUMMY=<yes|no> variable deprecating INTERFACETYPE=dummy.
@mtomaschewski mtomaschewski merged commit 9748369 into openSUSE:master May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants