Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PDM #920

Merged
merged 13 commits into from
Jan 5, 2024
Merged

Support PDM #920

merged 13 commits into from
Jan 5, 2024

Conversation

dbanty
Copy link
Collaborator

@dbanty dbanty commented Jan 1, 2024

A couple of things drive this change—first, PEP621 has been around for a while now and Poetry shows no signs of adopting it, so while I don't want to ditch Poetry support (it's very popular), I do want a way to generate that style of metadata. PDM seems like a good target for that.

Second, Poetry has deprecated some plugins we use... or something. I didn't look into it, but we're getting warnings on every project build now. So, seems like time to switch over to something else. Conveniently, this will make the development commands shorter (poetry run task check becomes pdm check).

TODO:

  • Convert this project to PDM
  • Support PDM metadata (which is partially PEP 621)
  • Update release workflows to use PDM as well
  • Document using PDM metadata in README
  • Double-check that py.typed is included with a generated PDM project
  • Add snapshot tests for different metadata types and test them as much as possible

@dbanty dbanty marked this pull request as ready for review January 5, 2024 01:15
@dbanty dbanty merged commit fa44ade into main Jan 5, 2024
20 checks passed
@dbanty dbanty deleted the pdm branch January 5, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant