Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.0.1 #734

Merged
merged 2 commits into from
Oct 11, 2018
Merged

Release v1.0.1 #734

merged 2 commits into from
Oct 11, 2018

Conversation

vbatts
Copy link
Member

@vbatts vbatts commented Oct 30, 2017

7c889fa Merge pull request #732 from wking/layout-no-slash-separated
ebd93fd Merge pull request #730 from elyscape/fix/platform-os-features-format
7c336bd Merge pull request #722 from coolljt0725/docker2oci
fd476dd Merge pull request #729 from vbatts/xeikeyang
bd85340 Merge pull request #726 from q384566678/digest-fix
61a96ff Merge pull request #727 from q384566678/validate-fix
7653c23 Merge pull request #723 from AkihiroSuda/fix-containerd
17baf95 Merge pull request #724 from vbatts/add_maintainer
97ae57f Merge pull request #721 from AkihiroSuda/update-readme
7100382 Merge pull request #715 from AkihiroSuda/nit
ef2b9a1 Merge pull request #714 from queicherius/patch-1

Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
@philips
Copy link
Contributor

philips commented Oct 31, 2017

LGTM

These are the only spec changes AFAICS, right?

7c889fa Merge pull request #732 from wking/layout-no-slash-separated
ebd93fd Merge pull request #730 from elyscape/fix/platform-os-features-format

Approved with PullApprove

@vbatts
Copy link
Member Author

vbatts commented Nov 8, 2017

I don't much care for this gometalinter. They can add plugins arbitrarily and now we're failing on it 👎

@philips you're correct. One more LGTM needed on this PR.

@vbatts
Copy link
Member Author

vbatts commented Nov 8, 2017

we'll track fixing the lint error in #735, as it is nothing that changed on our side, but some new linter upstream, or --excludes not working correctly.

@cyphar
Copy link
Member

cyphar commented Nov 8, 2017

LGTM.

Approved with PullApprove

@AkihiroSuda
Copy link
Member

CI should be green after rebase

@philips
Copy link
Contributor

philips commented Nov 27, 2017

LGTM

@vbatts vbatts merged commit 2e9bff2 into opencontainers:master Oct 11, 2018
@vbatts
Copy link
Member Author

vbatts commented Oct 11, 2018

wait shit.

@vbatts
Copy link
Member Author

vbatts commented Oct 11, 2018

oh right. yes. this was never merged. 1 (one!) year ago.

@vbatts vbatts deleted the release-v1.0.1 branch October 11, 2018 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants