Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pandoc: point to a joint OCI org image #814

Merged
merged 1 commit into from
Mar 31, 2021
Merged

pandoc: point to a joint OCI org image #814

merged 1 commit into from
Mar 31, 2021

Conversation

vbatts
Copy link
Member

@vbatts vbatts commented Dec 7, 2020

Signed-off-by: Vincent Batts vbatts@hashbangbash.com

@vbatts
pandoc: point to a joint OCI org image
4366201 
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
cyphar
cyphar approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jonjohnsonjr
Copy link
Contributor

Can we merge this?

@vbatts
Copy link
Member Author

vbatts commented Mar 24, 2021 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@vbatts
Copy link
Member Author

vbatts commented Mar 24, 2021

(i can't self approve ;-))

@jonjohnsonjr
Copy link
Contributor

@brendandburns @jbouzane @jstarks @jonboulle @stevvooe @xiekeyang

Can any of you approve this? CI is currently non-deterministically broken by Docker Hub rate limiting:

$ docker pull vbatts/pandoc
Using default tag: latest
Error response from daemon: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
The command "docker pull vbatts/pandoc" failed and exited with 1 during .

fuweid
fuweid approved these changes Mar 24, 2021
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid
Copy link
Member

fuweid commented Mar 24, 2021

@vbatts two approvals and ready to merge :)

@fuweid fuweid mentioned this pull request Mar 25, 2021
Closed
@vbatts vbatts merged commit 859973e into opencontainers:master Mar 31, 2021
@vbatts vbatts deleted the change_image branch March 31, 2021 16:49
@sudo-bmitch sudo-bmitch mentioned this pull request Sep 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelkarp samuelkarp samuelkarp approved these changes

@cyphar cyphar cyphar approved these changes

@jstarks jstarks jstarks approved these changes

@fuweid fuweid fuweid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vbatts @jonjohnsonjr @fuweid @samuelkarp @cyphar @jstarks