Add background to png images #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucianoqueiroz
requested review from
brendandburns,
cyphar,
jonboulle,
jonjohnsonjr,
jstarks,
stevvooe and
vbatts
as code owners
lucianoqueiroz
force-pushed
the
add-background-to-png-imgs
branch
2 times, most recently
from
8236907
to
e6d569f
Compare
On github darkmode is really hard to follow the specification because png images expects a light background. Signed-off-by: Luciano Queiroz <luciiano.queiroz@gmail.com>
lucianoqueiroz
force-pushed
the
add-background-to-png-imgs
branch
from
e6d569f
to
ee4bfe1
Compare
jonboulle
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On github darkmode is really hard to follow the specification because
png images expects a light background.
Before:
After: