Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: switch to golangci-lint #884

Merged
merged 3 commits into from
Dec 2, 2021
Merged

*: switch to golangci-lint #884

merged 3 commits into from
Dec 2, 2021

Conversation

vbatts
Copy link
Member

@vbatts vbatts commented Dec 2, 2021

Signed-off-by: Vincent Batts vbatts@hashbangbash.com

Fixes #876

Now this doesn't fix lint, but now makes main in a fixable way.

checking lint
specs-go/v1/index.go:24:15: `specificies` is a misspelling of `specifics` (misspell)
        // MediaType specificies the type of this document data structure e.g. `application/vnd.oci.image.index.v1+json`
                     ^
specs-go/v1/manifest.go:23:15: `specificies` is a misspelling of `specifics` (misspell)
        // MediaType specificies the type of this document data structure e.g. `application/vnd.oci.image.manifest.v1+json`
                     ^
schema/schema.go:20: File is not `goimports`-ed (goimports)
        "github.com/opencontainers/image-spec/specs-go/v1"
schema/loader.go:81:20: var-naming: method JsonSource should be JSONSource (revive)
func (l *fsLoader) JsonSource() interface{} { // nolint: golint
                   ^
schema/loader.go:120:20: var-naming: method JsonReference should be JSONReference (revive)
func (l *fsLoader) JsonReference() (gojsonreference.JsonReference, error) { // nolint: golint
                   ^
schema/backwards_compatibility_test.go:24: File is not `goimports`-ed (goimports)
        "github.com/opencontainers/image-spec/specs-go/v1"
schema/spec_test.go:98:7: `TOOD` is a misspelling of `TODO` (misspell)
                        // TOOD(stevvooe): This is nearly useless without file, line no.
                           ^
make: *** [Makefile:97: lint] Error 1

Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
Signed-off-by: Stephen Day <stephen.day@getcruise.com>
jonjohnsonjr
jonjohnsonjr previously approved these changes Dec 2, 2021
Signed-off-by: Stephen Day <stephen.day@getcruise.com>
@stevvooe
Copy link
Contributor

stevvooe commented Dec 2, 2021

Now this doesn't fix lint, but now makes main in a fixable way.

It does now! 😛

Copy link
Contributor

@stevvooe stevvooe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I have commits here, so prefer to have two other LGTMs before merge.

@vbatts
Copy link
Member Author

vbatts commented Dec 2, 2021

look at that 🟢 CI!

@vbatts vbatts merged commit a9fdc37 into opencontainers:main Dec 2, 2021
@vbatts vbatts deleted the fix_lint branch December 2, 2021 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BROKEN: github actions lint check is busted du to golang.org/x/tools changes
5 participants