Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maintainer nomination template #919

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

nishakm
Copy link
Contributor

@nishakm nishakm commented May 16, 2022

This is a PR template to propose adding new maintainers

Fixes #912

Signed-off-by: nisha nisha@ctlfsh.tech

@sajayantony
Copy link
Member

+1

@sudo-bmitch
Copy link
Contributor

I'd lean towards making the Justification section contain a comment describing possible ways to nominees could have activity, rather than fixed headings. It gives flexibility to participate in different ways. Some may attend meetings, respond on the mailing list, in slack, and I think all sorts of contributions should be valuable. The key part for me is whether they'll help respond to PRs since that's the primary responsibility for being a maintainer that I see.

I think we also want to look at what other templates would be useful, but that can be separate from this PR.

Comment on lines 13 to 17
### Community Activity

### Working Group Activity

### OCI Contributions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nishakm - want to just remove these 3 headings for now so we can get this in?

@nishakm
Copy link
Contributor Author

nishakm commented May 26, 2022

May 26 meeting: remove headings under justification and instead add comment on possible work a nominator can highlight

This is a PR template to propose adding new maintainers

Fixes opencontainers#912

Signed-off-by: nisha <nisha@ctlfsh.tech>
Copy link
Member

@jdolitsky jdolitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sudo-bmitch
Copy link
Contributor

@opencontainers/image-spec-maintainers PTAL

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdolitsky
Copy link
Member

Can we get a merge on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimum criteria for new maintainers?
7 participants