Update schema and tests for mediaType validation #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sajay Antony <sajaya@microsoft.com>
sajayantony
requested review from
jonjohnsonjr,
jonboulle,
stevvooe,
vbatts and
cyphar
as code owners
vbatts
approved these changes
Aug 10, 2022
sudo-bmitch
approved these changes
Aug 11, 2022
sudo-bmitch
pushed a commit
to sudo-bmitch/image-spec
that referenced
this pull request
Sep 25, 2022
Signed-off-by: Sajay Antony <sajaya@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally it would be better to make the
mediaTypea required property. But given that we want to be backward compatible, the check is left to the client to ensure that layers/config doesn't appear with the manifests then mediaType is not present.This PR doesn't attempt to fix that requirement in the schema and fixes only tests to have a valid mediaType.
-- Signed-off-by: Sajay Antony sajaya@microsoft.com