Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checkpoints integration tests failure #3913

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Fix checkpoints integration tests failure #3913

merged 1 commit into from
Jun 26, 2023

Conversation

fish98
Copy link
Contributor

@fish98 fish98 commented Jun 25, 2023

Checkpoint integration test failed when running the tests inside the docker container instead of local environment: make integration TESTPATH="/checkpoint.bats. The error are shown below:

# /go/src/github.com/opencontainers/runc/tests/integration/checkpoint.bats: line 288: ip: command not found

Fixed by adding the missing package iproute into the Dockerfile.

@fish98
Fix integration tests failure when calling "ip"
eb55472 
Signed-off-by: TTFISH <jiongchiyu@gmail.com>
kolyshkin
kolyshkin approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kolyshkin kolyshkin merged commit 1bc2999 into opencontainers:main Jun 26, 2023
36 checks passed
@kolyshkin
Copy link
Contributor

  1. This might need to be backported to 1.1.
  2. We're not hitting this in CI because we do not run tests through Docker.

@lifubang lifubang added the backport/todo/1.1 A PR in main branch which needs to be backported to release-1.1 label Jan 7, 2024
@kolyshkin kolyshkin mentioned this pull request Apr 2, 2024
Merged
@kolyshkin
Copy link
Contributor

1.1 backport: #4241

@kolyshkin kolyshkin added backport/done/1.1 A PR in main branch which was backported to release-1.1 and removed backport/todo/1.1 A PR in main branch which needs to be backported to release-1.1 labels Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolyshkin kolyshkin kolyshkin approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
area/ci backport/done/1.1 A PR in main branch which was backported to release-1.1 easy-to-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fish98 @kolyshkin @AkihiroSuda @lifubang