libcontainer/userns: migrate to github.com/moby/sys/userns #4350
+253
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 16, 2024
thaJeztah
force-pushed
the
migrate_userns
branch
from
cfb8cb4
to
8854ad2
Compare
thaJeztah
force-pushed
the
migrate_userns
branch
from
8854ad2
to
3d0a6e5
Compare
thaJeztah
changed the title
The userns package was moved to the moby/sys/userns module at commit 3778ae6. This patch deprecates the old location, and adds it as an alias for the moby/sys/userns package. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
migrate_userns
branch
from
3d0a6e5
to
a241e83
Compare
AkihiroSuda
reviewed
Aug 31, 2024
| @@ -1,8 +1,13 @@ | |||
| // Deprecated: use github.com/moby/sys/userns | |||
There was a problem hiding this comment.
Can we just remove libct/userns ?
There was a problem hiding this comment.
I think the concern is downstream users that import github.com/opencontainers/runc/libcontainer/userns. It seems there are a fair number of places that import this package unfortunately (though it seems they're mostly kubelet and kubelet forks and buildah?).
There was a problem hiding this comment.
Yes, correct; mostly to give potential users of this a warning that they should use the separate module instead. We can decide how long to keep the alias in place (although it doesn't give a significant amount of maintenance)
AkihiroSuda
approved these changes
Aug 31, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internal#3028The userns package was moved to moby/sys/userns module at commit 3778ae6.
This patch deprecates the old location, and adds it as an alias for the moby/sys/userns package.