Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sidecar variants #210

Merged
merged 2 commits into from
Sep 28, 2021
Merged

Add sidecar variants #210

merged 2 commits into from
Sep 28, 2021

Commits on Sep 17, 2021

  1. Remove whitespace from Go templates 

    Otherwise, unmarshalling and marshalling breaks long lines. This is an
issue e.g. for the `image` field of container definitions - if the
`image` field is made up of Helm values, then those must not be broken
up on whitespace or an error is caused. For consistency in the
templates, all Go templates have been aligned.

The issue was discovered during the implementation of the sidecar
feature, which parses tasks, modifies them, and then writes the "sidecar
task" to a new file.
    @michaelsauter
    michaelsauter committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    3ccf069 View commit details
    Browse the repository at this point in the history

  2. Add sidecar variants for tasks 

    The sidecar variants are the exact same task, with the addition of one
sidecar - the image for this sidecar needs to be specified.

Closes #135.
    @michaelsauter
    michaelsauter committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    f6011ab View commit details
    Browse the repository at this point in the history