Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix for stats API #287

Merged
merged 4 commits into from
Oct 22, 2020
Merged

Fix for stats API #287

merged 4 commits into from
Oct 22, 2020

Commits on Oct 22, 2020

  1. Add more tests

    @kaituo
    kaituo committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    251a0fc View commit details
    Browse the repository at this point in the history

  2. Fix for stats API 

    This PR fixes two issues for the stats API.

First, we didn't propagate multi-entity detectors' models execution exceptions for the remote invocation.  This problem may impact stats' API ability to report the total failures count and thus hide an issue we should have reported during monitoring.  This PR fixes the issue by collecting model host nodes' exceptions from coordinating nodes.

Second, we didn't show active multi-entity detectors' models information on stats API.  This PR places this information into stats API output.

This PR also adds unit tests for ModelManager.

Testing done:
1. added unit tests
2. manually verified the two issues are resolved.
    @kaituo
    kaituo committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    aa50ad5 View commit details
    Browse the repository at this point in the history

  3. Rename function

    @kaituo
    kaituo committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    21a8a54 View commit details
    Browse the repository at this point in the history

  4. remove unused variable

    @kaituo
    kaituo committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    5d27bfb View commit details
    Browse the repository at this point in the history