This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
fix null user in detector #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #301 +/- ##
============================================
+ Coverage 71.26% 71.28% +0.01%
- Complexity 1868 1869 +1
============================================
Files 194 194
Lines 9018 9020 +2
Branches 766 766
============================================
+ Hits 6427 6430 +3
+ Misses 2227 2224 -3
- Partials 364 366 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
saratvemulapalli
approved these changes
Oct 30, 2020
skkosuri-amzn
approved these changes
Oct 30, 2020
ylwu-amzn
commented
Oct 30, 2020
| @@ -448,7 +448,7 @@ private void indexAnomalyDetector(String detectorId) throws IOException { | |||
| anomalyDetector.getSchemaVersion(), | |||
| Instant.now(), | |||
| anomalyDetector.getCategoryField(), | |||
| anomalyDetector.getUser() | |||
| user | |||
There was a problem hiding this comment.
We didn’t put new user from thread context to detector, so the save will store null value
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Detector has null user as we can't get user from thread context and we don't set user in detector when create/update detector.
Test locally and on test cluster.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.