Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Adding role based filtering for rest of APIs #325

Merged
merged 9 commits into from
Dec 11, 2020

Conversation

saratvemulapalli
Copy link
Contributor

@saratvemulapalli saratvemulapalli commented Dec 7, 2020

*Issue #195 *

Description of changes:
Adding backend user role based filtering to Delete, Start/Stop, Get/Profile and Update APIs.
Also added support to block users creating detectors when AD Backend Role based filtering is turned on and user does not have backend roles.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #325 (31b4a9f) into master (f442efd) will decrease coverage by 0.76%.
The diff coverage is 45.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #325      +/-   ##
============================================
- Coverage     74.39%   73.62%   -0.77%     
+ Complexity     2022     2020       -2     
============================================
  Files           201      201              
  Lines          9563     9664     +101     
  Branches        852      860       +8     
============================================
+ Hits           7114     7115       +1     
- Misses         2019     2116      +97     
- Partials        430      433       +3     
Flag Coverage Δ Complexity Δ
cli 79.27% <ø> (ø) 0.00 <ø> (ø)
plugin 73.16% <45.00%> (-0.83%) 0.00 <13.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...opendistroforelasticsearch/ad/util/ParseUtils.java 45.66% <9.25%> (-11.92%) 31.00 <3.00> (+3.00) ⬇️
...transport/IndexAnomalyDetectorTransportAction.java 72.72% <64.00%> (-3.28%) 11.00 <5.00> (+5.00) ⬇️
...d/transport/GetAnomalyDetectorTransportAction.java 55.03% <78.57%> (+2.45%) 14.00 <2.00> (+2.00)
...d/transport/AnomalyDetectorJobTransportAction.java 81.57% <80.95%> (-2.43%) 5.00 <3.00> (+2.00) ⬇️
...ransport/DeleteAnomalyDetectorTransportAction.java 21.68% <83.33%> (-34.73%) 3.00 <0.00> (-11.00)
...port/SearchAnomalyDetectorInfoTransportAction.java 54.54% <0.00%> (-9.10%) 4.00% <0.00%> (ø%)
...asticsearch/ad/cluster/ADClusterEventListener.java 88.00% <0.00%> (-4.00%) 13.00% <0.00%> (-1.00%)
.../handler/IndexAnomalyDetectorJobActionHandler.java 10.84% <0.00%> (-0.61%) 3.00% <0.00%> (-1.00%)
...sticsearch/ad/indices/AnomalyDetectionIndices.java 49.01% <0.00%> (-0.33%) 39.00% <0.00%> (-1.00%)

Copy link
Contributor

@yizheliu-amazon yizheliu-amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the change

@saratvemulapalli saratvemulapalli added the enhancement New feature or request label Dec 9, 2020
@saratvemulapalli saratvemulapalli merged commit c949011 into master Dec 11, 2020
@saratvemulapalli saratvemulapalli deleted the fgac-role-based-filtering branch December 11, 2020 21:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants