Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paver python prereq paths #3487

Merged
merged 1 commit into from
May 28, 2014

Conversation

muhammad-ammar
Copy link
Contributor

Currently paver can't detect if something changed in requirements/edx/github.txt, requirements/edx/local.txt. Added these file paths in pavelib/prereqs.py so that correct prereqs are installed. Also deleted requirements/edx/repo.txt as it looks like that now no one is using it.

@muhammad-ammar
Copy link
Contributor Author

@jzoldak @wedaly Please Review. Thanks

@singingwolfboy
Copy link
Contributor

This seems like something that devops needs to review, rather than testeng or ORA. I've labeled the pull request as such.

@muhammad-ammar
Copy link
Contributor Author

@singingwolfboy Thanks

@jzoldak
Copy link
Contributor

jzoldak commented Apr 30, 2014

@e0d can you please review?
I think you were doing this (plus more?) in #3224 ?

@nedbat
Copy link
Contributor

nedbat commented May 1, 2014

#3224 certainly includes these changes and more. We should focus on getting it merged.

@jzoldak
Copy link
Contributor

jzoldak commented May 28, 2014

@clytwynec or @cpennington does this look good?
I'd rather get this in now than wait for the additional functionality in #3224

@clytwynec
Copy link
Contributor

👍

muhammad-ammar added a commit that referenced this pull request May 28, 2014
@muhammad-ammar muhammad-ammar merged commit 8809c5f into master May 28, 2014
@muhammad-ammar muhammad-ammar deleted the ammar/fix-paver-python-prereq-paths branch May 28, 2014 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants