Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Make filter poll lifetime configurable #5484

Closed
se3000 opened this issue Apr 20, 2017 · 20 comments · Fixed by #8885
Closed

Make filter poll lifetime configurable #5484

se3000 opened this issue Apr 20, 2017 · 20 comments · Fixed by #8885
Labels
F8-enhancement 🎊 An additional feature request. M6-rpcapi 📣 RPC API. P7-nicetohave 🐕 Issue is worth doing eventually. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow. Q3-medium A fair chunk of work, not necessarily very hard but not trivial either
Milestone
2.1 Whatever

Comments

@se3000
Copy link

se3000 commented Apr 20, 2017

Poll lifetime is currently hardcoded to 60 seconds. Scheduling software like cron runs at granularity of 60 seconds, and with high traffic, or a queue of filters to check, it's easy to exceed the 60 second lifetime.

Is it possible to make this configurable? Is there a downside?
@5chdn 5chdn added F8-enhancement 🎊 An additional feature request. M6-rpcapi 📣 RPC API. labels Apr 21, 2017
@5chdn 5chdn added the Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow. label Aug 22, 2017
@5chdn 5chdn added P7-nicetohave 🐕 Issue is worth doing eventually. and removed P7-nicetohave 🐕 Issue is worth doing eventually. labels Sep 5, 2017
@dawsonfi
Copy link

dawsonfi commented Oct 3, 2017

Hi @se3000,

Do you think that using an Toml file to hold this configuration would be a good idea?

@5chdn
Copy link
Contributor

5chdn commented Oct 4, 2017

toml is probably the best idea.

@dawsonfi
Copy link

dawsonfi commented Oct 4, 2017

Alright, i'll start working on it today.

I'm thinking on looking for a Toml file in the current and home folders of the user.
And if it doesn't have the property, we could use the default 60 seconds.

@rphmeier
Copy link
Contributor

rphmeier commented Oct 4, 2017

@dawsonfi wouldn't it make more sense to put this with the rest of the configuration in the CLI and config.toml?

@dawsonfi
Copy link

dawsonfi commented Oct 4, 2017

Sounds good to me @rphmeier, i'll take a look at the CLI and see how can i do this.

@5chdn 5chdn added this to the 1.10 & ... milestone Oct 5, 2017
@se3000
Copy link
Author

se3000 commented Oct 9, 2017 via email

@5chdn 5chdn modified the milestones: 1.10, 1.11 Jan 23, 2018
@5chdn 5chdn modified the milestones: 1.11, 1.12 Mar 1, 2018
@5chdn 5chdn modified the milestones: 1.12, 1.13 Apr 24, 2018
@folsen folsen added the Q3-medium A fair chunk of work, not necessarily very hard but not trivial either label May 19, 2018
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 0.18 ETH (100.82 USD @ $560.13/ETH) attached to it.

gnunicorn added a commit to gnunicorn/parity that referenced this issue Jun 13, 2018
@gnunicorn
Allow Poll Lifetime to be configured via CLI
ef4e79e 
... rather than it being a hard-coded constant. fixes openethereum#5484 .
@gnunicorn gnunicorn mentioned this issue Jun 13, 2018
Merged
gnunicorn added a commit to gnunicorn/parity that referenced this issue Jun 14, 2018
@gnunicorn
Allow Poll Lifetime to be configured via CLI
5f02a23 
... rather than it being a hard-coded constant. fixes openethereum#5484 .
gnunicorn added a commit to gnunicorn/parity that referenced this issue Jun 14, 2018
@gnunicorn
Allow Poll Lifetime to be configured via CLI
e8ce616 
... rather than it being a hard-coded constant. fixes openethereum#5484 .
debris pushed a commit that referenced this issue Jun 18, 2018
@gnunicorn @debris
Allow Poll Lifetime to be configured via CLI (#8885)
609d83f 
... rather than it being a hard-coded constant. fixes #5484 .
@debris
Copy link
Collaborator

debris commented Jun 20, 2018

I believe @gitcoinbot is wrong here. The issue is already resolved and the bounty belongs to @gnunicorn

@vs77bb
Copy link

vs77bb commented Jun 20, 2018 •
edited
Loading

@gnunicorn Mind clicking both 'Start Work' and 'Submit Work' on Gitcoin here in order to claim the bounty?

If you need a bit of ETH to make the submission, the Gitcoin Faucet can help!

Removed the other Gitcoiner for now 🙂

@gitcoinbot
Copy link

gitcoinbot commented Aug 1, 2018 •
edited
Loading

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 8 months, 1 week ago.
Please review their action plans below:

1) marcleuenberger1987 has started work.

What steps will you take to complete this task?

Example:dfddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddd
I'd start by implementing Netflify, then I'd make mockups for the /blog page and individual post pages and proceed with building them after getting some feedback from the team. I will start work on this right away and have it ready by the end of the weekend.

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

@marcleuenberger1987 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

5 similar comments
@gitcoinbot
Copy link

@marcleuenberger1987 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@marcleuenberger1987 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@marcleuenberger1987 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@marcleuenberger1987 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@marcleuenberger1987 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@5chdn
Copy link
Contributor

5chdn commented Aug 21, 2018

@vs77bb could you disable the bot here?

@gitcoinbot
Copy link

⚡️ A tip worth 0.18000 ETH (47.84 USD @ $265.77/ETH) has been granted to @gnunicorn for this issue from @vs77bb. ⚡️

Nice work @gnunicorn! Your tip has automatically been deposited in the ETH address we have on file.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 0.18 ETH (47.84 USD @ $265.77/ETH) attached to this issue has been approved & issued.

@vs77bb
Copy link

vs77bb commented Aug 22, 2018

@Tbaut Sorry about crazy Gitcoin Bot 😦 We introduced a new feature which allows us to pay out @gnunicorn without him 'submitting work', which is good. He has now been paid for his work here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
F8-enhancement 🎊 An additional feature request. M6-rpcapi 📣 RPC API. P7-nicetohave 🐕 Issue is worth doing eventually. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow. Q3-medium A fair chunk of work, not necessarily very hard but not trivial either
Projects
None yet
Milestone
2.1 Whatever
Development

Successfully merging a pull request may close this issue.

Allow Poll Lifetime to be configured via CLI gnunicorn/parity
8 participants
@folsen @se3000 @debris @dawsonfi @rphmeier @5chdn @vs77bb @gitcoinbot