Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

verbose flag for cpp tests #10524

Merged
merged 1 commit into from
Mar 26, 2019
Merged

verbose flag for cpp tests #10524

merged 1 commit into from
Mar 26, 2019

Conversation

TriplEight
Copy link
Collaborator

@TriplEight TriplEight commented Mar 26, 2019

Asked to to that in #10521

This test-cpp is not clear to me.
Latest thing happened to it before: when during FOSDEM we were fixing some critical stuff, ran into this test was launching Kovan sync and it took a long time, so we got rid of it and just left it there.

My opinion is the whole test should be revisited.

@parity-cla-bot
Copy link

It looks like @TriplEight signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@soc1c soc1c added A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. M1-ci 🙉 Continuous integration. labels Mar 26, 2019
@soc1c soc1c added this to the 2.5 milestone Mar 26, 2019
@TriplEight TriplEight merged commit 9cb8606 into master Mar 26, 2019
@ordian ordian deleted the test_cpp_verbose branch March 26, 2019 11:44
@soc1c soc1c added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. B1-patch-beta 🕷🕷 B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. and removed A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. labels Mar 26, 2019
soc1c pushed a commit that referenced this pull request Mar 27, 2019
@soc1c soc1c mentioned this pull request Mar 27, 2019
11 tasks
soc1c pushed a commit that referenced this pull request Mar 27, 2019
@soc1c soc1c mentioned this pull request Mar 27, 2019
11 tasks
soc1c added a commit that referenced this pull request Apr 1, 2019
* version: bump stable

* fix Sha3/keccak256 hash calculation for binaries (#10509)

#10495

* verbose flag for cpp tests (#10524)

* Initial support sccache for windows build (#10520)

* Initial support sccache for win build

* show sccache stats

* cache paths for shared runners

* sccache status is in the script.

* removed windows test for now

* ethcore: remove eth social and easthub chain configs (#10531)

* Fix max_gas (#10537)

Fix max_gas

* build android with cache, win fixes (#10546)

* build android with cache!

* windows fixes

* windows fixes 2

* windows fixes 3

* windows fixes 4

* windows should have sccache variables in env variables

* Update light client harcoded headers (#10547)

* kovan #10643457

* ropsten #5296129

* foundation #7460865

* classic #7747585

* indentation

* morden #3973121
soc1c added a commit that referenced this pull request Apr 1, 2019
* version: bump beta

* fix Sha3/keccak256 hash calculation for binaries (#10509)

#10495

* verbose flag for cpp tests (#10524)

* Initial support sccache for windows build (#10520)

* Initial support sccache for win build

* show sccache stats

* cache paths for shared runners

* sccache status is in the script.

* removed windows test for now

* ethcore: remove eth social and easthub chain configs (#10531)

* Fix max_gas (#10537)

Fix max_gas

* build android with cache, win fixes (#10546)

* build android with cache!

* windows fixes

* windows fixes 2

* windows fixes 3

* windows fixes 4

* windows should have sccache variables in env variables

* Update light client harcoded headers (#10547)

* kovan #10643457

* ropsten #5296129

* foundation #7460865

* classic #7747585

* indentation

* morden #3973121
ordian added a commit that referenced this pull request Apr 5, 2019
* master: (48 commits)
  ethcore: remove eth social and easthub chain configs (#10531)
  Initial support sccache for windows build (#10520)
  fix(light): make `OnDemand` generic instead of using the concrete type (#10514)
  private-tx: replace error_chain (#10510)
  Add trace information to eth_estimateGas (#10519)
  ethcore: add clique engine (#9981)
  verbose flag for cpp tests (#10524)
  Add a more realistic Batch test (#10511)
  docs: add changelogs for 2.3.{6,7,8} and 2.4.{1,2,3} (#10494)
  fix(rpc): fix a bunch of clippy lints (#10493)
  fix Sha3/keccak256 hash calculation for binaries (#10509)
  Add additional request tests (#10503)
  whisper/cli: add p2p port and ip parameters (#10057)
  fix(time-utils): add missing license (#10497)
  fix(extract `timestamp_checked_add` as lib) (#10383)
  fix(rpc): lint `unused_extern_crates` + fix warns (#10489)
  fix win&mac build (#10486)
  Сaching through docker volume (#10477)
  OpenBlock::new take IntoIterator instead of mutable ref to Iterator (#10480)
  simplify block module and usage (#10479)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. M1-ci 🙉 Continuous integration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants