Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Support EtherCore #11402

Merged
merged 1 commit into from
Jan 25, 2020
Merged

Support EtherCore #11402

merged 1 commit into from
Jan 25, 2020

Conversation

EtherCoreAdmin
Copy link
Contributor

@EtherCoreAdmin EtherCoreAdmin commented Jan 24, 2020 •
edited
Loading

Description

Support EtherCore Mainnet, Proof of Work Ethereum compatible network.

Homepage: https://ethercore.org
Block Explorer: https://explorer.ethercore.org
RPC Endpoint: https://rpc.ethercore.org
ChainId / SLIP-44: 466 satoshilabs/slips#847
Official Email: info@ethercore.org

ps) We use ProgPoW 0.9.3 version as suggested on Specification https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1057.md#specification - 0.9.2 version is considered as deprecated since it wouldn't benefit mining with AMD cards.

@parity-cla-bot
Copy link

It looks like @ethcoreorg hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, please reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@EtherCoreAdmin
Copy link
Contributor Author

[clabot:check]

@parity-cla-bot
Copy link

It looks like @ethcoreorg signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

ordian
ordian reviewed Jan 24, 2020
View reviewed changes
Copy link
Collaborator

@ordian ordian left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you please submit a different PR for updating ProgPoW to 0.93 so that it's easier to review and backport (please also mention

We use ProgPoW 0.9.3 version as suggested on Specification https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1057.md#specification - 0.9.2 version is considered as deprecated since it wouldn't benefit mining with AMD card

in the module docs)? Other than that, looks good to me.

@ordian ordian added A8-looksgood 🦄 Pull request is reviewed well. M2-config 📂 Chain specifications and node configurations. M4-core ⛓ Core client code / Rust. labels Jan 24, 2020
@ordian ordian removed the M4-core ⛓ Core client code / Rust. label Jan 24, 2020
niklasad1
niklasad1 suggested changes Jan 24, 2020
View reviewed changes
Copy link
Collaborator

@niklasad1 niklasad1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use explicit activate_at 0 for all builtins for verbosity/readability and this should be ready to be merged.

@EtherCoreAdmin
Add EtherCore support
f3f0759 
* support ethercore mainnet with basic token metrics and ProgPoW support, ecip1017, bomb defuse & istanbul
@EtherCoreAdmin
Copy link
Contributor Author

@niklasad1 Addressed comments!

@EtherCoreAdmin
Copy link
Contributor Author

Builtin now match with foundation and ropsten specs https://github.com/paritytech/parity-ethereum/blob/master/ethcore/res/ethereum/ropsten.json#L3328

niklasad1
niklasad1 approved these changes Jan 24, 2020
View reviewed changes
Copy link
Collaborator

@niklasad1 niklasad1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, thank you

Even though I prefer to have explicit activation if it missing it will be assigned to 0

@sorpaas sorpaas merged commit 33bfcec into openethereum:master Jan 25, 2020
@EtherCoreAdmin EtherCoreAdmin mentioned this pull request Jan 27, 2020
Merged
s3krit pushed a commit that referenced this pull request Jan 27, 2020
@EtherCoreAdmin @s3krit
Add EtherCore support (#11402)
90fccf9 
* support ethercore mainnet with basic token metrics and ProgPoW support, ecip1017, bomb defuse & istanbul
dvdplm added a commit that referenced this pull request Jan 29, 2020
@dvdplm
Merge branch 'master' into dp/chore/use-latest-attempt-to-switch-to-u…
c3a4fa7 
…pstream

* master:
  Add POSDAO transition and malice report queue. (#11245)
  update master/nightly version: v2.8.0 (#11419)
  ethcore/res: remove morden testnet (#11392)
  fix: export hardcoded sync format (#11416)
  update hardcoded headers: mainnet and ropsten (#11414)
  AuthorityEngine: Minor cleanups. (#11408)
  Update POA bootnodes (#11411)
  Add EtherCore support (#11402)
  verification: fix race same block + misc (#11400)
  Update ProgPoW to 0.9.3 (#11407)
  update classic testnet bootnodes (#11398)
  dependencies: bump `derive_more v0.99` (#11405)
  engine error: remove faulty/unused `From` (#11404)
  Switching to stable-track (#11377)
  ethcore/res: fix ethereum classic chainspec blake2_f activation block num (#11391)
  Update copyright notice 2020 (#11386)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ordian ordian ordian approved these changes

@sorpaas sorpaas sorpaas approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M2-config 📂 Chain specifications and node configurations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@EtherCoreAdmin @parity-cla-bot @ordian @sorpaas @niklasad1