Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

gcc to clang #11453

Merged
merged 2 commits into from
Feb 5, 2020
Merged

gcc to clang #11453

merged 2 commits into from
Feb 5, 2020

Conversation

General-Beck
Copy link
Contributor

test

export CC="sccache "$CC
export CXX="sccache "$CXX

darwin build

CC=clang
CXX=clang

@General-Beck
gcc to clang
0c1d470 
test
```
export CC="sccache "$CC
export CXX="sccache "$CXX
```
darwin build
```
CC=clang
CXX=clang
```
@General-Beck General-Beck added A0-pleasereview 🤓 Pull request needs code review. A8-backport 🕸 Pull request is already reviewed well in another branch. M1-ci 🙉 Continuous integration. labels Feb 5, 2020
@General-Beck General-Beck self-assigned this Feb 5, 2020
TriplEight
TriplEight approved these changes Feb 5, 2020
View reviewed changes
Copy link
Collaborator

@TriplEight TriplEight left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, $CC and $CXX are set in the CI docker image

@niklasad1 niklasad1 added B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. A8-looksgood 🦄 Pull request is reviewed well. and removed A8-backport 🕸 Pull request is already reviewed well in another branch. A0-pleasereview 🤓 Pull request needs code review. labels Feb 5, 2020
s3krit
s3krit approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@s3krit s3krit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@s3krit s3krit merged commit 7108b3f into master Feb 5, 2020
s3krit pushed a commit that referenced this pull request Feb 5, 2020
@General-Beck @s3krit
gcc to clang (#11453)
ec7e883 
* gcc to clang

test
```
export CC="sccache "$CC
export CXX="sccache "$CXX
```
darwin build
```
CC=clang
CXX=clang
```

* darwin - > default clang
@ordian ordian deleted the ci-gcc-clang branch February 5, 2020 14:11
ordian added a commit that referenced this pull request Feb 5, 2020
@ordian
Merge branch 'master' into ao-fix-rlp-calltype-backwards-compatible
c317584 
* master:
  gcc to clang (#11453)
  Avoid copies (#11451)
  Cargo.lock: cargo lock translate (#11448)
  Avoid long state queries when serving GetNodeData requests (#11444)
  Cargo.lock: cargo update -p kvdb-rocksdb (#11447)
s3krit added a commit that referenced this pull request Feb 5, 2020
@s3krit @soc1c
@niklasad1 @holiman @dvdplm @ordian @General-Beck
V2.7.2 stable (#11454)
d961010 
* update classic testnet bootnodes (#11398)

* update classic testnet bootnodes

* Update kotti.json

* Update kotti.json

* Update kotti.json

* Update mordor.json

* verification: fix race same block + misc (#11400)

* ethcore: fix race in verification

* verification: fix some nits

* verification: refactor err type `Kind::create`

* fix: tests

* address grumbles

* address grumbles: don't panic

* fix: export hardcoded sync format (#11416)

* fix: export hardcoded sync format

* address grumbles

* make tests compile with rustc_hex 2.0

* fix grumbles: impl LowerHex for encoded Header

* goerli: replace foundation bootnode (#11433)

* Remove dead bootnodes, add new geth bootnodes (#11441)

* update kvdb-rocksdb to 0.4 (#11442)

* Avoid long state queries when serving GetNodeData requests (#11444)

* Remove dead bootnodes, add new geth bootnodes

* More granular locking when fetching state
Finish GetDataNode requests early if queries take too long

* typo

* Use latest kvdb-rocksdb

* Cleanup

* Update ethcore/sync/src/chain/supplier.rs

Co-Authored-By: Andronik Ordian <write@reusable.software>

* Address review grumbles

* Fix compilation

* Address review grumbles

Co-authored-by: Andronik Ordian <write@reusable.software>

* rlp_derive: cleanup (#11446)

* rlp_derive: update syn & co

* rlp_derive: remove dummy_const

* rlp_derive: remove unused attirubutes

* rlp-derive: change authors

* Cargo.lock: cargo update -p kvdb-rocksdb (#11447)

* Cargo.lock: new lockfile format

Manual backport of #11448

* gcc to clang (#11453)

* gcc to clang

test
```
export CC="sccache "$CC
export CXX="sccache "$CXX
```
darwin build
```
CC=clang
CXX=clang
```

* darwin - > default clang

* Bump version and CHANGELOG.md

* chore: remove unused dependencies (#11432)

* fix: compiler warnings

* chore: remove unused dependencies

* Update CHANGELOG.md

* update Cargo.lock

* update CHANGELOG.md

* backwards compatible call_type creation_method (#11450)

* rlp_derive: update syn & co

* rlp_derive: remove dummy_const

* rlp_derive: remove unused attirubutes

* rlp-derive: change authors

* rlp_derive: add rlp(default) attribute

* Revert "Revert "[Trace] Distinguish between `create` and `create2` (#11311)" (#11427)"

This reverts commit 5d4993b.

* trace: backwards compatible call_type and creation_method

* trace: add rlp backward compatibility tests

* cleanup

* i know, i hate backwards compatibility too

* address review grumbles

* update CHANGELOG.md

* just to make sure we don't screw up this again (#11455)

* Update CHANGELOG.md

Co-authored-by: Talha Cross <47772477+soc1c@users.noreply.github.com>
Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
Co-authored-by: Martin Holst Swende <martin@swende.se>
Co-authored-by: David <dvdplm@gmail.com>
Co-authored-by: Andronik Ordian <write@reusable.software>
Co-authored-by: Denis S. Soldatov aka General-Beck <general.beck@gmail.com>
dvdplm added a commit that referenced this pull request Feb 8, 2020
@dvdplm
Merge branch 'master' into dp/chore/use-latest-attempt-to-switch-to-u…
66103c1 
…pstream

* master:
  upgrade some of the dependencies (#11467)
  Some more release track changes to README.md (#11465)
  Update simple one-line installer due to switching to a single stable release track (#11463)
  update Dockerfile (#11461)
  Implement EIP-2124 (#11456)
  [eth classic chainspec]: remove `balance = 1` (#11459)
  just to make sure we don't screw up this again (#11455)
  backwards compatible call_type creation_method (#11450)
  gcc to clang (#11453)
  Avoid copies (#11451)
  Cargo.lock: cargo lock translate (#11448)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s3krit s3krit s3krit approved these changes

@TriplEight TriplEight TriplEight approved these changes

Assignees

@General-Beck General-Beck

Labels
A8-looksgood 🦄 Pull request is reviewed well. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. M1-ci 🙉 Continuous integration.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@General-Beck @s3krit @TriplEight @niklasad1