Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fixing dapps sorting #3086

Merged
merged 3 commits into from
Nov 2, 2016
Merged

Fixing dapps sorting #3086

merged 3 commits into from
Nov 2, 2016

Conversation

ngotchac
Copy link
Contributor

@ngotchac ngotchac commented Nov 2, 2016

Fixes #3076

@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. M6-ui labels Nov 2, 2016
@@ -25,6 +25,6 @@

.item {
display: inline-block;
margin: 0 0 0.25em;
width: 100%;
margin: 0.25%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the margins at 0.25em on the accounts list, would like to keep consistency throughout

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, fixed (nb: 0.125em but for each which makes 0.25em for a two column layout)

@jacogr jacogr added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 2, 2016
@jacogr
Copy link
Contributor

jacogr commented Nov 2, 2016

Spacing still off (Accounts vs Apps) -

parity 2016-11-02 11-47-52

parity 2016-11-02 11-47-32

@ngotchac
Copy link
Contributor Author

ngotchac commented Nov 2, 2016

Should be ok now

@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Nov 2, 2016
@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 2, 2016
@jacogr jacogr merged commit ed89e1e into master Nov 2, 2016
@jacogr jacogr deleted the ng-dapps-list-fix branch November 2, 2016 11:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants