Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

fetch known code from the database during restoration #3377

Merged
merged 4 commits into from
Nov 14, 2016

Conversation

rphmeier
Copy link
Contributor

previously it kept all seen code in memory, leading to high memory usage by the end of state restoration.

Lowers memory usage by ~150MB when warp syncing.
Related to #3304

previously it kept all seen code in memory, leading to
high memory usage by the end of state restoration
@rphmeier rphmeier added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Nov 11, 2016
@gavofyork
Copy link
Contributor

js-tests fail :-S

[ci:skip]
@gavofyork
Copy link
Contributor

does a test hit this codepath?

@rphmeier
Copy link
Contributor Author

Haven't touched any JS here. I think that the snap_and_restore test will hit this codepath but I can write another specialized one as well.

@rphmeier
Copy link
Contributor Author

Ok, test added.

@rphmeier
Copy link
Contributor Author

Think this one should be a B0-patch?

@gavofyork gavofyork added B0-patch A8-looksgood 🦄 Pull request is reviewed well. A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. and removed A0-pleasereview 🤓 Pull request needs code review. A8-looksgood 🦄 Pull request is reviewed well. labels Nov 12, 2016
@rphmeier rphmeier added A8-looksgood 🦄 Pull request is reviewed well. and removed A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. labels Nov 14, 2016
@gavofyork gavofyork merged commit 2989ab9 into master Nov 14, 2016
@gavofyork gavofyork deleted the missing-code-by-prefix branch November 14, 2016 15:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants