Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up media that were created during a scenario. #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pfrenssen
Copy link
Member

@pfrenssen pfrenssen commented Oct 1, 2019

This is a WIP implementation of #103 but unfortunately I am running out of time on my ticket and I can not finish this unless we get a dedicated ticket for this. Here is the code so far. The idea is to not rely on magic for cleaning up media entities created during a scenario, but to keep track of the entities that are created, and clean them up at the end of the test.

@vever001
Copy link
Contributor

Just leaving a small comment here because I remember seeing something similar in lightning which perhaps could be of use:

@pfrenssen
Copy link
Member Author

Yeah they should not do automatic cleanup either, but clean them up manually at the end. When doing a UI test then entities created through the UI should be deleted through the UI. Cleaning up things automatically will hide potential bugs regarding handling of orphaned references etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants