Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EWPP-3010: Drupal 10 compatibility. #212

Merged
merged 17 commits into from
Apr 3, 2023
Merged

EWPP-3010: Drupal 10 compatibility. #212

merged 17 commits into from
Apr 3, 2023

Conversation

brummbar
Copy link
Contributor

No description provided.

drupaltest/behat-traits has lower dependency tests which are usually
quite troublesome to fix. Since we use only one method, which never
changed in the past years, we decided to drop the dependency.
sergepavle
sergepavle previously approved these changes Apr 3, 2023
@@ -7,43 +7,27 @@
"prefer-stable": true,
"require": {
"php": ">=8.0",
"drupal/core": "^9.4",
"drupal/core": "^9.4 || ^10",
"ext-json": "*"
},
"require-dev": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_readme is outdated already.

protected $httpKernel;

/**
* Constructs a LacoServiceMiddleware object.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Constructs a LacoServiceMiddleware object.
* Constructs a LacoServiceMiddlewareBase object.

@brummbar brummbar merged commit 6d05e84 into master Apr 3, 2023
@brummbar brummbar deleted the EWPP-3010 branch April 3, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants