Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(model): run tests against a built-in OpenFGA engine #142

Merged
merged 9 commits into from
Sep 6, 2023

Conversation

rhamzeh
Copy link
Member

@rhamzeh rhamzeh commented Aug 29, 2023

Description

  • Update README
  • Decide on whether to keep remote option
  • Update the OpenFGA dependency once fixed upstream

Notes:

  • Complex examples with > 20 contextual tuples won't run against remote engines b/c contextual tuples > than the limit.
Screenshot 2023-08-29 at 7 01 16 AM

References

Testing

  1. Clone this branch
  2. Run make build
  3. Run ./dist/fga model test --tests example/tests.fga.yaml

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@rhamzeh rhamzeh force-pushed the feat/run-tests-locally branch 2 times, most recently from 47a2dae to 4b1dd5f Compare August 29, 2023 11:04
@rhamzeh rhamzeh added the enhancement New feature or request label Aug 29, 2023
@rhamzeh rhamzeh self-assigned this Aug 29, 2023
@rhamzeh rhamzeh force-pushed the feat/run-tests-locally branch 3 times, most recently from 9c536e2 to e88198b Compare August 30, 2023 13:47
@rhamzeh rhamzeh marked this pull request as ready for review September 6, 2023 18:27
@rhamzeh rhamzeh requested a review from a team as a code owner September 6, 2023 18:27
@rhamzeh rhamzeh added this pull request to the merge queue Sep 6, 2023
Merged via the queue into main with commit aedcff0 Sep 6, 2023
16 checks passed
@rhamzeh rhamzeh deleted the feat/run-tests-locally branch September 6, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run tests against a built-in OpenFGA engine instead of requiring a remote engine
2 participants