fix: correct flag value type in delete, import, and write #389

ewanharris · 2024-09-09T07:46:48Z

Description

Overlooked the need to change the flag declaration as part of the refactoring here #382.

Will work on adding some integration tests to cover this.

Fixes #387

I have clicked on "allow edits by maintainers".
I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
The correct base branch is being used, if not main
I have added tests to validate that the change in functionality is working as expected

Fixes #387

cmd/tuple/import.go

ewanharris requested a review from a team as a code owner September 9, 2024 07:46

fix: correct flag value type in delete, import, and write

dc43c71

Fixes #387

ewanharris force-pushed the fix/correct-type-on-max-tuples-and-requests branch from 8bf614b to dc43c71 Compare September 9, 2024 08:27

stevehobbsdev reviewed Sep 9, 2024

View reviewed changes

cmd/tuple/import.go Outdated Show resolved Hide resolved

rhamzeh previously approved these changes Sep 9, 2024

View reviewed changes

refactor: remove nolint comment

57338c3

ewanharris dismissed rhamzeh’s stale review via 57338c3 September 9, 2024 10:55

ewanharris requested a review from rhamzeh September 9, 2024 10:59

rhamzeh approved these changes Sep 9, 2024

View reviewed changes

ewanharris added this pull request to the merge queue Sep 9, 2024

Merged via the queue into main with commit 52c4302 Sep 9, 2024
16 checks passed

ewanharris deleted the fix/correct-type-on-max-tuples-and-requests branch September 9, 2024 11:32